Tweak autoloader for Windows #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoshoku Could you please check this? |
mrkn
commented
Jul 13, 2021
| lib_dirs.find do |d| | ||
| x = Dir.glob("#{d}/lib#{l}{,64}.#{lib_ext}{,.*}").find do |lib| | ||
| begin | ||
| Fiddle.dlopen(lib).close |
There was a problem hiding this comment.
Use Fiddle.dlopen here to examine the candidate files can be dlopen-ed.
yoshoku
reviewed
Jul 14, 2021
| false | ||
| else | ||
| true | ||
| end |
There was a problem hiding this comment.
This is a smart way to find a loadable library 👍
yoshoku
reviewed
Jul 14, 2021
| @@ -64,7 +64,12 @@ def load_library | |||
| end | |||
|
|
|||
| def detect_library_extension | |||
| case RbConfig::CONFIG['host_os'] | |||
| # Ruby >= 2.5 provides SOEXT in rbconfig | |||
| so_ext = RbConfig::CONFIG["SOEXT"] | |||
There was a problem hiding this comment.
I am happy to know such a useful config value 👍
yoshoku
reviewed
Jul 14, 2021
yoshoku
approved these changes
Jul 14, 2021
Ruby Installer 2 adds the bin directory of MSYS2 (DEVKIT) in the default DLL directories. Trying to seach DLLs in the default search directories makes us easy to use OpenBLAS and LAPACK installed by pacman command.
|
@masa16 How do you think this? |
|
This may fix #35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tweaks the autoloader for Windows, especially for Ruby Installer 2.
Ruby Installer 2 adds the bin directory of its MSYS2 (a.k.a. DEVKIT) in the default DLL search directories. This directory is the location of the DLLs installed by pacman command.
If we try libraries only with their names like
Fiddle.dlopen("libopenblas.dll")first, the autoloader makes it easier to use libraries installed by pacman command.