Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add passkey keyword to after_passkey_authentication #26

Merged
merged 5 commits into from Jun 24, 2023
Merged

Add passkey keyword to after_passkey_authentication #26

merged 5 commits into from Jun 24, 2023

Conversation

Vagab
Copy link
Contributor

@Vagab Vagab commented Jun 23, 2023 •
edited

resolves #14

@Vagab
Copy link
Contributor Author

Vagab commented Jun 23, 2023

@tcannonfodder let me know if I should add any tests

@tcannonfodder
Copy link
Contributor

Yep, we definitely need tests for this 💪

@Vagab
Copy link
Contributor Author

Vagab commented Jun 23, 2023

@tcannonfodder I see in a rails user model a comment saying we're checking that the validations were confirmed(here) but I wasn't able to find where do we actually check that 🥲 . Could you point me in the right direction? In the meanwhile, I've added tests for this callback into reauthentication integration test.

@tcannonfodder
Copy link
Contributor

I...actually don't know if we're using those checks 😅. I need to dig into the tests. It's one of the places where devise gets gnarly because of how it's designed

@tcannonfodder
Copy link
Contributor

Okay, it looks like that code is vestigial, from a previous implementation attempt. We should remove it in a subsequent PR

@tcannonfodder tcannonfodder mentioned this pull request Jun 24, 2023
Closed
@tcannonfodder tcannonfodder self-requested a review June 24, 2023 20:22
@tcannonfodder
Copy link
Contributor

Waiting on CI to pass, but looks good! 💪

@tcannonfodder
Copy link
Contributor

Ack, @Vagab can you rebase the latest main into this so that we can get CI to pass?

@tcannonfodder tcannonfodder merged commit eaaaf65 into ruby-passkeys:main Jun 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcannonfodder tcannonfodder tcannonfodder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add passkey keyword parameter to PasskeyAuthenticatable.after_passkey_authentication
2 participants
@Vagab @tcannonfodder