Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested packages don't work correctly, custom options don't parse. #16

Closed
xaviershay opened this issue Jul 15, 2012 · 2 comments
Closed
Labels

Comments

@xaviershay
Copy link

Not really sure where to put this. I made some commits against ruby-protobuf, which seems to have a similar compiler as this project. This isn't quite ready for a pull request, but wanted to link it up some fixes to save anyone reinventing it:

https://github.com/xaviershay/ruby-protobuf/compare/fixes

@localshred
Copy link
Contributor

Thanks for the report. I've rewritten the compiler to inherit from libprotoc which should solve this issue. I've explicitly left out custom options for the time being, but will be adding support for them in a few weeks. I'll keep this open to remind me of the custom opts.

@localshred
Copy link
Contributor

Though I said otherwise, closing this issue. I'll make a new issue for a feature to support custom options.

evanboho pushed a commit to evanboho/protobuf that referenced this issue Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants