Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #48. Fix reset_changes. #49

Closed
wants to merge 2 commits into from
Closed

Issue #48. Fix reset_changes. #49

wants to merge 2 commits into from

Conversation

mohideen
Copy link

Clear changed attributes only when there are changes

@mohideen
Issue ruby-rdf#48. Fix reset_changes.
8971d73 
Clear changed attributes only when there are changes
@mohideen mohideen mentioned this pull request Jun 11, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-8.9%) to 89.342% when pulling 8971d73 on mohideen:patch-1 into 5cfaa9c on ruby-rdf:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-8.9%) to 89.342% when pulling 8971d73 on mohideen:patch-1 into 5cfaa9c on ruby-rdf:develop.

@coveralls
Copy link

coveralls commented Jun 11, 2018 •
edited

Coverage Status

Coverage decreased (-8.8%) to 89.427% when pulling 45e48e4 on mohideen:patch-1 into 5cfaa9c on ruby-rdf:develop.

@mohideen
Updated as per feedback
45e48e4 
- Use not Nil check instead of 'changed?'
- Added spec tests
@abrisse
Copy link
Member

abrisse commented Jun 26, 2018

See #47

@abrisse abrisse closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohideen @coveralls @abrisse