-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert removing BigDecimal.new in version 1.4 for very old version of Rails #114
Comments
Good idea. A lot of code depends on this. In theory, it shouldn't be removed until Ruby 3.0 because it's a backwards incompatible change? |
No, I don't think so because bigdecimal is just a standard library, but not ruby's core. I have a plan to release version 1.5.0 with removing BigDecimal.new. Users can control what version of bigdecimal is used by calling |
If you are using semantic versioning you should not remove public interface in minor version bump. It should be 2.0.0 release to change or remove existing interface in backwards incompatible way. |
bigdecimal doesn’t employ semantic versioning. |
What kind of versioning does it use? |
An awful lot of people will use |
All I can say, is that I agree that:
|
I think it is good idea that version 2.0.0 follows version 1.4.0 because I can release bigdecimal 3.0.0 when CRuby 3.0 is released. So, these are my decision:
|
This issue was closed and isn't about versioning topic. |
I've created https://bugs.ruby-lang.org/issues/15456 for further discussion. I invite everyone to get involved. |
I decided to revert removing
BigDecimal.new
on bigdecimal 1.4 because very old version of Rails depends on it.After releasing Ruby 2.6, I will release bigdecimal 1.5 without
BigDecimal.new
.Reference
The text was updated successfully, but these errors were encountered: