Enhanced RDoc for bigdecimal.c #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should have a documentation label, but that label does not (yet) exist. |
olleolleolle
approved these changes
Oct 15, 2021
mrkn
reviewed
Nov 12, 2021
| * BigDecimal("1e-20").precision # => 20 | ||
| * BigDecimal("Infinity").precision # => 0 | ||
| * BigDecimal("-Infinity").precision # => 0 | ||
| * BigDecimal("NaN").precision # => 0 |
There was a problem hiding this comment.
I like the previous format in the output example. Please revert this part.
mrkn
reviewed
Nov 12, 2021
|
@mrkn, ready for review. |
mrkn
requested changes
Nov 12, 2021
ext/bigdecimal/bigdecimal.c
Outdated
| * if the neighbors are equidistant, round away from zero. | ||
| * Aliased as +:half_up+ and +:default+. | ||
| * - +ROUND_HALF_DOWN+: Round toward the nearer neighbor; | ||
| * if the neighbors are equidistant, round toward from zero. |
|
@mrkn, I'm not positive I've addressed all your points. Can you confirm? |
|
@mrkn, is this ready to merge? |
mrkn
approved these changes
Nov 17, 2021
|
@BurdetteLamar Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treats: