Add .to_s('F') digit grouping for integer part #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkn
requested changes
Jul 3, 2023
mrkn
approved these changes
Jul 5, 2023
|
Looks like this broke some Active Support tests: |
|
This change does not related to ruby versions. |
Merged
zzak
added a commit
to zzak/rails
that referenced
this pull request
Jul 9, 2023
The previous examples were causing failures in CI, after ruby/bigdecimal#264 was merged. For example: ``` Failure: NumericExtFormattingTest#test_default_to_fs [/rails/activesupport/test/core_ext/numeric_ext_test.rb:446]: --- expected +++ actual @@ -1 +1,3 @@ -"10000 10.0" +# encoding: US-ASCII +# valid: true +"10 00010.0" ``` The recommendation was to adjust the test to deal with the upstream change more flexibly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now to_s('F') digit grouping works properly only for fractional part. For integer part result is unspecified. In reality we also get grouping, but of unpractical nature:
This patch fixes grouping of integer part:
I consider this change backwards compatible as:
a) docs say only about grouping fractional part, no declarations about grouping integer part,
b) total string length without changes,
c) integer part grouping didn't make sense so there should be no or not much real life dependencies.
Also added some tests.