Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen the domain regex to accept '.' #29

Merged
merged 5 commits into from
Nov 28, 2022
Merged

Loosen the domain regex to accept '.' #29

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77fb46c
Loosen the domain regex to accept '.'
tubaxenor Nov 23, 2022
6a49473
Update lib/cgi/cookie.rb
tubaxenor Nov 24, 2022
59c20fe
Merge branch 'master' into relax-domain-label-more
hsbt Nov 25, 2022
1d1517a
Merge branch 'master' into relax-domain-label-more
hsbt Nov 28, 2022
718a590
Merge branch 'master' into relax-domain-label-more
hsbt Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cgi/cookie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class Cookie < Array

TOKEN_RE = %r"\A[[!-~]&&[^()<>@,;:\\\"/?=\[\]{}]]+\z"
PATH_VALUE_RE = %r"\A[[ -~]&&[^;]]*\z"
DOMAIN_VALUE_RE = %r"\A(?<label>(?!-)[-A-Za-z0-9]+(?<!-))(?:\.\g<label>)*\z"
DOMAIN_VALUE_RE = %r"\A(?<label>(?!-)\.?[-A-Za-z0-9]+(?<!-))(?:\.\g<label>)*\z"
tubaxenor marked this conversation as resolved.
Show resolved Hide resolved

# Create a new CGI::Cookie object.
#
Expand Down
3 changes: 3 additions & 0 deletions test/cgi/test_cgi_cookie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ def test_cgi_cookie_new_with_domain
cookie = CGI::Cookie.new('domain'=>'a.example.com', **h)
assert_equal('a.example.com', cookie.domain)

cookie = CGI::Cookie.new('domain'=>'.example.com', **h)
assert_equal('.example.com', cookie.domain)

cookie = CGI::Cookie.new('domain'=>'1.example.com', **h)
assert_equal('1.example.com', cookie.domain, 'enhanced by RFC 1123')

Expand Down