Fix CSV delegation to missing StringIO methods #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested changes
Mar 13, 2019
If you create a `CSV` from raw content like:
csv = CSV.new("h1,h2")
You'll get method missing when calling `csv.path` but still get true
when you call `csv.respond_to?(:path)`.
This tricks 3rd party libraries like `carrierwave` which try to call
`#path` on their input if it responds to it.
See https://github.com/carrierwaveuploader/carrierwave/blob/a91ab69fdd8052cdf5a5e48ef8baf40939e441fb/lib/carrierwave/sanitized_file.rb#L109-L123
This stops me from passing `CSV` objects as `StringIO` into
`carrierwave` uploads, for example, but the problem can also be
manifested in other 3rd party libraries, as responding to a method and
returning a `NoMethodError` when calling it is still an unexpected
behavior.
I have went through the `CSV` delegation scheme and made sure that every
method that `StringIO` doesn't respond to returns a meaningful zero value
and does not raise a `NoMethodError` while used through a `CSV` Instance.
|
Thanks for taking a look, @kou! I have changed some of the operations to return |
|
Did you push? It seems that there is no new commit. |
gsamokovarov
force-pushed
the
csv-stringio-missing-methods-delegation
branch
from
837cb39
to
cb83cd7
Compare
|
Yes! I did forget... 🤦♂️ Can you check now? 😅 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create a
CSVfrom raw content like:You'll get a
NoMethodErrorwhen callingcsv.pathbut still get true whenyou call
csv.respond_to?(:path).This tricks 3rd party libraries like
carrierwavewhich try to call pathon their input, if it responds to it.
See https://github.com/carrierwaveuploader/carrierwave/blob/a91ab69fdd8052cdf5a5e48ef8baf40939e441fb/lib/carrierwave/sanitized_file.rb#L109-L123
This stops me from passing
CSVobjects asStringIOs intocarrierwaveuploads, for example, but the problem can also be manifested in other
3rd party libraries, as responding to a method and returning a
NoMethodErrorwhen calling it is still an unexpected behavior.I have gone through the
CSVdelegation scheme and made sure that everymethod
StringIOdoesn't respond to returns a meaningful zero valueand does not raise a
NoMethodErrorwhile used through aCSVInstance.Ref. ruby/ruby#2094