New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced RDoc #58
Enhanced RDoc #58
Conversation
BurdetteLamar
commented
Jul 6, 2022
•
edited
edited
- Brings a dozen call-seq schemas into compliance with the doc guide.
- Adds links to section "Argument start" where needed.
- Revises (minorly) ::today.
- Otherwise, does not disturb existing text.
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
ext/date/date_core.c
Outdated
@@ -2473,6 +2473,8 @@ date_s__valid_jd_p(int argc, VALUE *argv, VALUE klass) | |||
* | |||
* Date.valid_jd?(2451944) # => true | |||
* | |||
* See {Argument start}[rdoc-ref:Date@Argument+start]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use something like
* See {Argument start}[rdoc-ref:Date@Argument+start]. | |
* See {Argument +start+}[rdoc-ref:Date@Argument+start]. |
to match the title it links to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (17 places).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked this, it looks like RDoc doesn't handle formatting inside links, so it ends up being broken. Sorry about that. Maybe we can revert back to what it was like originally or something like {Argument "start"}[rdoc-ref:Date@Argument+start]
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original, or maybe See argument {start} [rdoc-ref:Date@Argument+start]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like See argument {start}[rdoc-ref:Date@Argument+start]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@peterzhu2118, ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor typo, otherwise looks good!
@@ -4508,6 +4515,8 @@ date_s__parse(int argc, VALUE *argv, VALUE klass) | |||
* Raise an ArgumentError when the string length is longer than _limit_. | |||
* You can stop this check by passing `limit: nil`, but note that | |||
* it may take a long time to parse. | |||
^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo:
^ | |
* |
Brings a dozen call-seq schemas into compliance with the doc guide. Adds links to section "Argument start" where needed. Revises (minorly) ::today. Otherwise, does not disturb existing text. ruby/date@9aec11df50