Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test builder #161

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Improve test builder #161

merged 2 commits into from
Jul 12, 2021

Conversation

ono-max
Copy link
Collaborator

@ono-max ono-max commented Jul 11, 2021

There are 2 points I implemented.

1. Test builder don't capitalize the first letter of class name.

Now

# frozen_string_literal: true

require_relative '../support/test_case'

module DEBUGGER__
  class deletetest < TestCase
    def program
      <<~RUBY
        1| a = 1
        1| b = 2
        2| c = 3
        3| d = 4
      RUBY
    end

Expected

# frozen_string_literal: true

require_relative '../support/test_case'

module DEBUGGER__
  class Deletetest < TestCase
    def program
      <<~RUBY
        1| a = 1
        1| b = 2
        2| c = 3
        3| d = 4
      RUBY
    end

2. When the string "test" is in the prefix, it won't be removed.

Now

$ bin/gentest target.rb  -c deletetest -m test_delete_keeps_current_breakpoints_if_not_confirmed
...
appended: /Users/naotto/workspace/debug/test/tool/../debug/deletetest_test.rb
    method: test_delete_keeps_current_breakpoints_if_not_confirmed

Expected

$ bin/gentest target.rb  -c deletetest -m test_delete_keeps_current_breakpoints_if_not_confirmed
appended: /Users/naotto/workspace/debug/test/tool/../debug/delete_test.rb
    method: test_delete_keeps_current_breakpoints_if_not_confirmed

@ko1 ko1 merged commit 97a6c56 into ruby:master Jul 12, 2021
@ono-max ono-max deleted the improve-test-builder branch July 12, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants