-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure to enable check_line_num
only when Github Workflow.
#210
Conversation
check_line_num
only when Github Workflow.
…n Github Workflow
bd04160
to
5334c31
Compare
I hope this PR will solve your problem :) |
@ono-max thank you for the PR! |
It doesn't make sense to me. You can run $ RUBY_DEBUG_TEST_CHECK_LINE_NUM=true rake test |
I'd like to avoid running tests with another env var when possible. The behavior I'm looking for is simple:
With the correct verification order, it's done automatically by the test framework (like it used to do). But now it only does I added #211 to demonstrate the change. |
Thank you for giving me much detailed information. There are some stuff I would like to confirm with you.
|
Yes, it should be automatic because it "was" automatic.
Don't you think it's weird that users have to rely on CI to finish their test case? Especially for something that could've been done locally. |
Ok, I am convinced with your opinion. I close my PR. |
As #209 (comment), we need the option for disabling
check_line_num!
method. I added the environment variable inutils.rb
andruby.yml
to makecheck_line_num!
valid only when Github Workflow.Of course, we can also enable it in local environment by adding environment variable such as
$ RUBY_DEBUG_TEST_CHECK_LINE_NUM=true rake test