Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give correct arguments to "respond_fail" method #468

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

ono-max
Copy link
Collaborator

@ono-max ono-max commented Dec 30, 2021

When "respond_fail" method is called, debugger raise an Exception as follows:

#<Thread:0x00007fc98c067568@DEBUGGER__::SESSION@server /Users/naotto/workspace/debug/lib/debug/session.rb:147 run> terminated with exception (report_on_exception is true):
/Users/naotto/workspace/debug/lib/debug/server_cdp.rb:527:in `respond_fail': wrong number of arguments (given 2, expected 1) (ArgumentError)
	from /Users/naotto/workspace/debug/lib/debug/server_cdp.rb:551:in `fail_response'
	from /Users/naotto/workspace/debug/lib/debug/server_cdp.rb:632:in `cdp_event'
	from /Users/naotto/workspace/debug/lib/debug/session.rb:294:in `process_event'
	from /Users/naotto/workspace/debug/lib/debug/session.rb:197:in `session_server_main'
	from /Users/naotto/workspace/debug/lib/debug/session.rb:167:in `block in activate'
/Users/naotto/workspace/debug/lib/debug/server_cdp.rb:527:in `respond_fail': wrong number of arguments (given 2, expected 1) (ArgumentError)
	from /Users/naotto/workspace/debug/lib/debug/server_cdp.rb:551:in `fail_response'
	from /Users/naotto/workspace/debug/lib/debug/server_cdp.rb:632:in `cdp_event'
	from /Users/naotto/workspace/debug/lib/debug/session.rb:294:in `process_event'
	from /Users/naotto/workspace/debug/lib/debug/session.rb:197:in `session_server_main'
	from /Users/naotto/workspace/debug/lib/debug/session.rb:167:in `block in activate'
NAOTOs-MacBook-Pro-7:debug naotto$ exe/rdbg target.rb --open=chrome

The reason of this exception is that debugger doesn't expand the hash. This PR fixes it.

@ko1 ko1 merged commit 6193c87 into ruby:master Jan 4, 2022
@ono-max ono-max deleted the patch-4 branch January 10, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants