Do not override an existed thread in the testing framework #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
force-pushed
the
patch-30
branch
2 times, most recently
from
05267fb
to
6c991fd
Compare
ono-max
changed the title
ono-max
changed the title
|
Is this a cause of random CI failures? |
|
Hopefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thread for storing debuggee's output is defined https://github.com/ruby/debug/blob/master/test/support/utils.rb#L333 as a
reader_threadin remote_info. However, it's overridden in https://github.com/ruby/debug/pull/511/files#diff-a1bc4fb86b4a4e8cc3d94199a4d2b9152c2c8da2261be54d0529942f64a8105dL155. This PR fixes it.