[Fix bug] modify assert_line_text method to be able to make correct assertions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Jun 8, 2021
test/support/utils.rb
Outdated
| line.include? expected | ||
| result = false | ||
| @internal_info['backlog'].each do |line| | ||
| if line.include? expected |
There was a problem hiding this comment.
can you use match? instead of include? so it can also take regexp as expectation?
There was a problem hiding this comment.
ono-max
force-pushed
the
hotfix/modify-assert-line-text-method
branch
from
1b99dd2
to
e97c30b
Compare
ko1
reviewed
Jun 8, 2021
test/support/utils.rb
Outdated
| end | ||
| end | ||
| assert_true(result) |
There was a problem hiding this comment.
It should show failure message. When the test fails, there is no hints and it is difficult to debug.
There was a problem hiding this comment.
Thanks, I will add it.
ono-max
force-pushed
the
hotfix/modify-assert-line-text-method
branch
from
e97c30b
to
d747c12
Compare
ono-max
force-pushed
the
hotfix/modify-assert-line-text-method
branch
from
d747c12
to
d4fe7ba
Compare
st0012
reviewed
Jun 8, 2021
test/support/utils.rb
Outdated
| assert_block do | ||
| @internal_info['backlog'].each do |line| | ||
| line.include? expected | ||
| msg = "Expected to include #{expected}}" |
There was a problem hiding this comment.
it still doesn't provide much information:
Expected to include => 20}.
<true> expected but was
<false>
how about this?
assert_match(expected, @internal_info['backlog'].join) </=>\ 20/> was expected to be =~
<"=>#0\tFoo#first_call at /var/folders/yg/hnbymwxd5pn7v94_clc59y6r0000gn/T/debugger20210608-65153-b857w.rb:4 #=> 30\n" +
" #1\t<main> at /var/folders/yg/hnbymwxd5pn7v94_clc59y6r0000gn/T/debugger20210608-65153-b857w.rb:23\n">.
There was a problem hiding this comment.
That's a good idea! Thanks 👍
There was a problem hiding this comment.
ono-max
force-pushed
the
hotfix/modify-assert-line-text-method
branch
from
d4fe7ba
to
518ba5b
Compare
|
btw it'd be great if we can merge this sooner than later because the current matcher doesn't take regexp object and never fails when passing string 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.