Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve assert methods #86

Closed
wants to merge 3 commits into from
Closed

Improve assert methods #86

wants to merge 3 commits into from

Conversation

ono-max
Copy link
Collaborator

@ono-max ono-max commented Jun 13, 2021

  • Override assert_block method to call create_message only when test fails
  • use assert_block to output clearer fail logs

ono-max
ono-max commented Jun 13, 2021
View reviewed changes
test/support/utils.rb
Comment on lines +7 to +12
#
# assert methods based on test-unit project
#
# The License is https://github.com/test-unit/test-unit/blob/master/BSDL
#

Copy link
Collaborator Author

@ono-max ono-max Jun 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is enough for requirements in License of test-unit.
I'd like some advices

@ono-max ono-max marked this pull request as ready for review June 13, 2021 12:06
@ko1
Copy link
Collaborator

ko1 commented Jun 16, 2021

please consider the way without redefine the existing assert methods.

@ko1 ko1 closed this Jun 16, 2021
@ono-max ono-max deleted the improve-assertion branch June 17, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ono-max @ko1