Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Trial implementation of test code for debbuger -single process #9

Closed
wants to merge 14 commits into from

Conversation

ono-max
Copy link
Collaborator

@ono-max ono-max commented May 14, 2021

やったこと

やってないこと

  • popenを試す
  • テストが実行されたりされなかったりすることのバグ修正


$LOAD_PATH.unshift(__dir__)

require 'minitest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use "test-unit" instead of minitest ?

ruby/ruby migrates minitest to test-unit in this year.

Copy link
Collaborator Author

@ono-max ono-max May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsbt
Could you teach me detail about it?
I wasn't able to find any reference about the migration.

Copy link
Member

@hsbt hsbt May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see rubygems/rubygems#3141

Basically, ruby/ruby uses test-unit, not minitest. rubygems and psych only uses minitest namespace. I did migrate them to test-unit in May, 2021.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator Author

@ono-max ono-max May 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@st0012 st0012 mentioned this pull request May 19, 2021
@ono-max ono-max changed the title [WIP] Trial implementation of test code for debbuger [WIP] Trial implementation of test code for debbuger -single process May 20, 2021
ono-max referenced this pull request in ono-max/debug May 23, 2021
Show more pretty backtrace like:

```
(rdbg) bt
=>#0    block{|i=0, j=nil|} (3 levels) in foo at ~/src/rb/target.rb:12
  #1    [C] Integer#times at ~/src/rb/target.rb:11
  #2    rescue in rescue in block (2 levels) in foo at ~/src/rb/target.rb:11
  #3    rescue in block (2 levels) in foo at ~/src/rb/target.rb:8
  #4    block (2 levels) in foo at ~/src/rb/target.rb:5
  #5    [C] Integer#times at ~/src/rb/target.rb:4
  #6    block{|e=2|} in foo at ~/src/rb/target.rb:4
  #7    [C] Range#each at ~/src/rb/target.rb:3
  #8    [C] Enumerable#map at ~/src/rb/target.rb:3
  #9    Object#foo(a=3) at ~/src/rb/target.rb:3
  #10   <main> at ~/src/rb/target.rb:20
```
@ono-max ono-max closed this May 25, 2021
@ono-max ono-max deleted the trial-test branch June 17, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants