Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-head fails on test/test_verbose_formatter.rb:17 #160

Closed
olleolleolle opened this issue Aug 15, 2021 · 2 comments · Fixed by #162
Closed

ruby-head fails on test/test_verbose_formatter.rb:17 #160

olleolleolle opened this issue Aug 15, 2021 · 2 comments · Fixed by #162

Comments

@olleolleolle
Copy link
Contributor

CI on ruby-head fails with the following output.

This happened at least since this build on 2021-06-30: https://github.com/ruby/did_you_mean/runs/2948189838?check_suite_focus=true

Details

This is the test output:

Failure: test_message(VerboseFormatterTest):
  </undefined\ method\ `zeor\?'\ for\ 1:Integer\n\n\ \ \ \ Did\ you\ mean\?\ zero\?/> was expected to be =~
  <"undefined method `zeor?' for 1:Integer\n" +
  "\n" +
  "    @error = assert_raise(NoMethodError){ 1.zeor? }\n" +
  "                                           ^^^^^^\n" +
  "\n" +
  "    Did you mean? zero?\n" +
  " ">.
/home/runner/work/did_you_mean/did_you_mean/test/test_verbose_formatter.rb:17:in `test_message'
     14:   def test_message
     15:     @error = assert_raise(NoMethodError){ 1.zeor? }
     16: 
  => 17:     assert_match <<~MESSAGE.strip, @error.message
     18:       undefined method `zeor?' for 1:Integer
     19: 
     20:           Did you mean? zero?
===============================================================================
@yuki24
Copy link
Member

yuki24 commented Aug 16, 2021

It's probably due to the newly added https://github.com/ruby/error_highlight. Shouldn't be too difficult to fix by just disabling it.

cc @mame

@olleolleolle
Copy link
Contributor Author

Thanks, @mame , for finding & repairing this!

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants