Call uniq on spell checker corrections

[laynemcnish]

I have noticed duplications in suggestions when ActiveSupport's TimeWithZone objects using the Comparable mixin are called with a misspelled method.

=> Time.zone.now.between(1.hour.ago, 1.hour.from_now)
NoMethodError: undefined method `between' for Fri, 24 Mar 2017 15:30:47 UTC +00:00:Time
Did you mean?  between?
Did you mean?  between?

I am having trouble testing the fix locally and would love advice on how to test that my change has made a difference.

[yuki24]

I have seen the same issue and it is definitely an issue that should be fixed. However, I'm not convinced that this is a bug in the spell checker, as the entire message (Did You mean? X) gets duplicated. This may possibly be because of the DYM gem being loaded twice, that would result in monkey-patching NameError twice.

Do you have gem 'did_you_mean' in the Gemfile or explicitly require 'did_you_mean' somewhere in your app?

[laynemcnish]

@yuki24 I don't have the gem in the gemfile or explicitly required. I made an empty rails 5 project here: https://github.com/laynemcnish/test_project When using the rails console, I have the same issue occur when using: Time.zone.now.between(1.hour.ago, 1.hour.from_now).

I haven't been able to get it to happen with other methods so I'm wondering if it has something to do with how Rails using the TimeWithZone & Comparable mixin.

[yuki24]

Thanks for taking your time on making a test app! I'll look into it.

[yuki24]

The root cause was the NameError#to_s method that used to always attempt to append a suggestion even after a NoMethodError is re-raised (or raised multiple times). I have just pushed a fix and cut two new releases 1.1.3 and 1.0.3. Thanks for reporting the issue!

[laynemcnish]

Thanks for the explanation and the fix! I really appreciate it!