ReImplement KeyNameChecker using CRuby's new API #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki24
reviewed
Sep 24, 2017
There was a problem hiding this comment.
I'd like to promote this to a first-class feature as it is no longer necessary to monkey-patch the Hash class.
KeyNameCheckershould be moved tolib/did_you_mean/spell_checkersSPELL_CHECKERS["KeyError"] = KeyNameCheckershould be moved tolib/did_you_mean.rb
| @@ -1,31 +1,43 @@ | |||
| module DidYouMean | |||
| module Experimental | |||
| module KeyErrorWithNameAndKeys | |||
| FILE_REGEXP = %r"#{Regexp.quote(__FILE__)}" | |||
| if KeyError.method_defined?(:receiver) && KeyError.method_defined?(:key) | |||
There was a problem hiding this comment.
You don't have to worry about backward-compatibility since GH master is only compatible with the latest Ruby (2.5.0-dev at the time of writing).
| end | ||
| Hash.prepend KeyErrorWithNameAndKeys |
There was a problem hiding this comment.
This module could be removed entirely.
test/experimental/key_error_test.rb
Outdated
| @@ -12,4 +12,37 @@ def test_corrects_hash_key_name | |||
| assert_correction %("foo"), error.corrections | |||
| assert_match %(Did you mean? "foo"), error.to_s | |||
| end | |||
|
|
|||
| if KeyError.method_defined?(:receiver) && KeyError.method_defined?(:key) | |||
There was a problem hiding this comment.
I think we could always run these tests since Ruby 2.5.0 (and later) is the only version DYM 1.2.0 is going to be compatible with.
|
Thank you for reviewing. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRuby v2.5 will be able to call
KeyError#receiverandKeyError#key.I reimplement
KeyNameCheckerusing it.We'll be able to support suggesting
Hash#fetch_values,Kernel#sprintfandENV#[]also ;)refs:
KeyErrorchecker #71