Add ruby predefined objects to variable name checker #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @yuki24.
I'm thinking of adding predefined objects (
false
,true
, andnil
) in the variable name checker dictionary. Their 2.4 deprecated toplevel constants are already included, but the objects themselves are not.The constants:
but, the objects:
I need to be reminded of these objects too.
I don't know how to get the predefined objects in the nice way so I just write them in an array.
Since
nil
return""
when called withto_s
, I replaced it with:nil
.Should I wrote all of them in symbols ([:false, :true, :nil]) to make it consistent with the others?
If this PR is merged: