Change const_missing require for SHA2 #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require sha2.rb instead of sha2.so. With a change proposed for Ruby feature 15856, once sha2.so is loaded, require 'sha2' will not load sha2.rb, resulting in Digest::SHA2 not being defined in the following case: ```ruby require "digest" p Digest::SHA256 #=> Digest::SHA256 p Digest::SHA2 ``` As digest/sha2.rb requires digest/sha2.so, this should not cause any backwards compatibility issues. Patch from Dan0042 (Daniel DeLorme)
|
@nobu came up with a better approach for fixing Ruby issue 15856 (ruby/ruby#4674) that does not require this change, so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require sha2.rb instead of sha2.so. With a change proposed for
Ruby feature 15856, once sha2.so is loaded, require 'sha2' will
not load sha2.rb, resulting in Digest::SHA2 not being defined
in the following case:
As digest/sha2.rb requires digest/sha2.so, this should not cause
any backwards compatibility issues.
Patch from Dan0042 (Daniel DeLorme)