Integrate the JRuby extension #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
👍 looks good to me. |
|
👍 LGTM I don't think that the final java gemfile should be shipped with C sources - ext/digest/** and vice versa. But it's a detail. |
|
@ahorek You have a point. I added a commit to address that. |
nobu
reviewed
Sep 29, 2021
nobu
reviewed
Sep 29, 2021
knu
force-pushed
the
jruby_ext_integration
branch
from
e140ed1
to
2855e3e
Compare
|
I've squashed some commits. I think I can merge this later today. Thank you all for taking a look! |
|
Some commits, CI changes and dropping ext/openssl, seem better to be separated from this issue. |
|
I think that the @eregon's idea, mapping |
It would be good to get JRuby's feedback on that, I opened jruby/jruby#6865 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is based on #21. Ruby engine specific parts now reside in their respective
ext/*directories, while keeping the common parts inlib/.