url_encode: use CGI.escapeURIComponent

Ref: ruby/cgi#26 This native implementation is much faster and available in `cgi 0.3.3`.
ruby · Oct 25, 2022 · 83ea8c8 · 83ea8c8
1 parent a3492c4
commit 83ea8c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/erb.gemspec b/erb.gemspec
@@ -27,5 +27,5 @@ Gem::Specification.new do |spec|
   spec.executables   = ['erb']
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'cgi'
+  spec.add_dependency 'cgi', '>= 0.3.3'
 end
diff --git a/lib/erb.rb b/lib/erb.rb
@@ -1019,9 +1019,7 @@ def html_escape(s)
     #   Programming%20Ruby%3A%20%20The%20Pragmatic%20Programmer%27s%20Guide
     #
     def url_encode(s)
-      s.to_s.b.gsub(/[^a-zA-Z0-9_\-.~]/n) { |m|
-        sprintf("%%%02X", m.unpack1("C"))
-      }
+      CGI.escapeURIComponent(s.to_s)
     end
     alias u url_encode
     module_function :u