Structured memory deallocation using blocks #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisseaton
commented
Jun 3, 2020
chrisseaton
commented
- Easy to use best-practice
- Helps people write correct code for the most common cases
- Protect against leaks (free if there's an exception, or even if someone uses a trace point to get hold of the object)
- Protect against deallocation latency (free as soon as you're done)
- Protect against non-locality (free while it's still in cache from your using it)
kou
reviewed
Jun 4, 2020
ext/fiddle/pointer.c
Outdated
| return obj; | ||
| if (rb_block_given_p()) { | ||
| if (f == NULL) { | ||
| rb_raise(rb_eFiddleError, "a free function must be supplied to Fiddle::Pointer.malloc when it is called with a block"); |
ext/fiddle/pointer.c
Outdated
| @@ -261,7 +271,14 @@ rb_fiddle_ptr_s_malloc(int argc, VALUE argv[], VALUE klass) | |||
| obj = rb_fiddle_ptr_malloc(s,f); | |||
| if (wrap) RPTR_DATA(obj)->wrap[1] = wrap; | |||
|
|
|||
| return obj; | |||
| if (rb_block_given_p()) { | |||
| if (f == NULL) { | |||
There was a problem hiding this comment.
Suggested change
| if (f == NULL) { | |
| if (!f) { |
Because we don't use == NULL in other places.
test/fiddle/test_pointer.rb
Outdated
|
|
||
| def test_malloc_block_no_free | ||
| assert_raise Fiddle::DLError do | ||
| Pointer.malloc(10) { |ptr| raise } |
There was a problem hiding this comment.
Could you remove needless raise? raise in assert_raise may confuse us.
Suggested change
| Pointer.malloc(10) { |ptr| raise } | |
| Pointer.malloc(10) { |ptr| } |
|
Sorry I didn't use 'commit suggestion' I hadn't seen that before in GitHub and didn't realise it was an option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.