Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced RDoc for FileUtils #67

Merged
merged 2 commits into from
May 11, 2022
Merged

Enhanced RDoc for FileUtils #67

merged 2 commits into from
May 11, 2022

Conversation

BurdetteLamar
Copy link
Member

Treats:

  • ::pwd
  • ::cd
  • ::uptodate?
  • ::mkdir

lib/fileutils.rb Outdated
# Returns true if +new+ is newer than all +old_list+.
# Non-existent files are older than any file.
# Returns +true+ if the file at path +new+
# is newer than all the files at paths in array +old_list+.;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the period is a typo

Suggested change
# is newer than all the files at paths in array +old_list+.;
# is newer than all the files at paths in array +old_list+;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

lib/fileutils.rb Outdated
Comment on lines 198 to 199
# Creates directories at the paths in the given +list+ (an array of strings);
# returns +list+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention that list could also be a string (to create just a single directory).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BurdetteLamar BurdetteLamar merged commit ee43008 into ruby:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants