Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement generator for aws-sdk #118

Merged
merged 11 commits into from Feb 10, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Feb 6, 2022

What

Merge ksss/aws-sdk-rbs-generator

As discussed in #110, I was preparing a big change about the generator for aws-sdk.
This is ksss/aws-sdk-rbs-generator.
This is a generator that completely replaces the generators/aws-sdk.

This PR add new generator in generators/aws-sdk-rbs-generator.
And delete generators/aws-sdk.

Why

Support Client#wait_until

Added support for Client#wait_until, which is a method that outputs differently depending on the argument.

Support Resource classes

This change will allow us to generate signatures for the resource class as well as the traditional client class.
The resource class is, for example, the Aws::S3::Resource class.

resource = Aws::S3::Resource.new
obj = resource.bucket('a').object('b')
#=> We will be able to check that obj is an instance of Aws::S3::Object !

How to operate

The generator will always overwrite and regenerate the target file.

Whenever an auto-generated file needs to be modified, the generator needs to be modified.

For classes that are not auto-generated, simply place the files under gems/aws-sdk-*/. This process is exactly the same as aws-sdk-ruby.

@ksss ksss requested a review from pocke as a code owner February 6, 2022 13:31
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@pocke pocke merged commit 87be3bc into ruby:main Feb 10, 2022
@ksss ksss deleted the merge-ksss/aws-sdk-rbs-generator branch February 10, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants