Add RBS files for sinatra and sinatra-contrib gems #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated initial RBS files using the `rbs prototype rb` command, and added type definitions for both the Sinatra core and contributed extensions. https://github.com/sinatra/sinatra/tree/v4.0.0 I have set myself as the reviewer for this change because I believe the sinatra gem is an important and widely-used web framework. However, I am not very familiar with sinatra, so if there is someone who uses sinatra regularly and is motivated to maintain these type definitions, I would appreciate it if they could take over the reviewer role.
|
@euglena1215 Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated initial RBS files using the
rbs prototype rbcommand, and added type definitions for both the Sinatra core and contributed extensions.https://github.com/sinatra/sinatra/tree/v4.0.0
I have set myself as the reviewer for this change because I believe the sinatra gem is an important and widely-used web framework. However, I am not very familiar with sinatra, so if there is someone who uses sinatra regularly and is motivated to maintain these type definitions, I would appreciate it if they could take over the reviewer role.