Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Array in Sinatra::JSON#json argument #567

Merged
merged 1 commit into from
May 27, 2024

Conversation

euglena1215
Copy link
Contributor

Sinatra::JSON#json was able to properly encode a list of objects as JSON, but was unable to represent them as types.

Fixed this so that Arrays are also accepted with type overloading.

`Sinatra::JSON#json` was able to properly encode a list of objects as JSON, but was unable to represent them as types.

Fixed this so that Arrays are also accepted with type overloading.
Copy link

@euglena1215 Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

sinatra-contrib

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.


sinatra

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.

@euglena1215
Copy link
Contributor Author

/merge

@github-actions github-actions bot merged commit 1cbe291 into ruby:main May 27, 2024
4 checks passed
@euglena1215 euglena1215 deleted the fix-sinatra-json branch May 27, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant