Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default completion background color #328

Closed
ianks opened this issue Jan 8, 2022 · 6 comments
Closed

Change default completion background color #328

ianks opened this issue Jan 8, 2022 · 6 comments

Comments

@ianks
Copy link

ianks commented Jan 8, 2022

Description

When starting IRB in Ruby 3.1, autocomplete suggestions are shown but hard to read due to the default background color. Ideally, the default background color settings would ensure enough contrast to make the text legible.

Screen Shot 2022-01-08 at 12 22 23 PM

Result of irb_info

Please paste the result of irb_info command in IRB.

ex.)

irb(main):001:0> irb_info
=>
Ruby version: 3.1.0                            
IRB version: irb 1.4.1 (2021-12-25)            
InputMethod: ReidlineInputMethod with Reline 0.3.0
RUBY_PLATFORM: arm64-darwin21                  
LANG env: en_US.UTF-8                          
East Asian Ambiguous Width: 1                  

Terminal Emulator

VSCode terminal

Setting Files

Are you using ~/.irbrc and ~/.inputrc?

No I am not

@ianks
Copy link
Author

ianks commented Jan 8, 2022

I believe #328 would allow for this

@kaiquekandykoga
Copy link
Contributor

I believe #328 would allow for this

The link provided is redirecting to the same page.

@osyo-manga
Copy link
Contributor

This?
ruby/reline#413

@sshock
Copy link

sshock commented Mar 5, 2022

Making it configurable would be great! Looking forward to ruby/reline#413 and #337 being approved and merged!

But the default should be fixed too. White text on a bright cyan background is just plain awful. Can we at least make the background dark cyan?

@pocari
Copy link

pocari commented May 28, 2022

Having made the changes as advised by @st0012, it is now simple to change the default background and foreground color. Now it is just a matter of specifying the appropriate value in the block that sets the default value.

@ima1zumi
Copy link
Member

Fixed ruby/reline#552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants