Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions/revisions to help-message #370

Merged
merged 2 commits into from Jul 7, 2022
Merged

Additions/revisions to help-message #370

merged 2 commits into from Jul 7, 2022

Conversation

BurdetteLamar
Copy link
Member

Changed:

  • Added text to options that said just 'same as ruby -whatever'.
  • Added defaults.
  • Removed an errant tab.

I'm not adding the documentation label, because I'm not sure about how else this might be used.

If/when approved, section "Command line options" in irb.rb will need to be updated.

@BurdetteLamar
Copy link
Member Author

@hsbt, I'm not sure whether @aycabta is fully back in action; may I request a review from you, if you think that would be best?

@BurdetteLamar
Copy link
Member Author

@hsbt, I'm not sure that @aycabta is back in action. Can you suggest someone to review this? Thanks.

Co-authored-by: Peter Zhu <peter@peterzhu.ca>
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented Jul 7, 2022

@peterzhu2118, this is now approved, but not by the maintainer. Can it be merged?

@peterzhu2118
Copy link
Member

This is probably fine to merge.

@BurdetteLamar BurdetteLamar merged commit dfe454c into ruby:master Jul 7, 2022
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 7, 2022
Changed:

    Added text to options that said just 'same as ruby -whatever'.
    Added defaults.
    Removed an errant tab.

ruby/irb@dfe454cc33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants