Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kernel.warn to print command alias warning #601

Merged
merged 1 commit into from Jun 10, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jun 10, 2023

This aligns with other warnings in IRB and properly channels the message to stderr.

@st0012 st0012 added the bug Something isn't working label Jun 10, 2023
@st0012 st0012 requested a review from a team June 10, 2023 11:33
@st0012 st0012 self-assigned this Jun 10, 2023
lib/irb/extend-command.rb Outdated Show resolved Hide resolved
This aligns with other warnings in irb and properly channel the message
to stderr.
@st0012 st0012 force-pushed the print-command-alias-warning-with-warn branch from 79df65e to 4c19793 Compare June 10, 2023 13:24
@st0012 st0012 requested a review from tompng June 10, 2023 13:25
@st0012 st0012 changed the title Use warn to print command alias warning Use Kernel.warn to print command alias warning Jun 10, 2023
@tompng tompng merged commit 2049666 into master Jun 10, 2023
47 checks passed
@tompng tompng deleted the print-command-alias-warning-with-warn branch June 10, 2023 15:01
matzbot pushed a commit to ruby/ruby that referenced this pull request Jun 10, 2023
(ruby/irb#601)

This aligns with other warnings in irb and properly channel the message
to stderr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

2 participants