Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stanardise test class names with Test postfix instead of prefix #603

Merged
merged 1 commit into from Jun 13, 2023
Merged

Stanardise test class names with Test postfix instead of prefix #603

merged 1 commit into from Jun 13, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jun 12, 2023

  1. I think it's better to standardise test class names so things are more clear

  2. I prefer SomethingTest instead of TestSomething because we sometimes also name some stub/mock class, like TestInputMethod. So the latter is more ambiguous.

    • Another reason is that ruby-lsp detects code-lens activation on SomethingTest only.

    Screenshot 2023-06-12 at 12 20 26

@st0012 st0012 requested a review from a team June 12, 2023 11:25
hasumikin
hasumikin approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@hasumikin hasumikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st0012 st0012 merged commit 359cb28 into master Jun 13, 2023
47 checks passed
@st0012 st0012 deleted the standardise-test-class-names branch June 13, 2023 11:02
matzbot pushed a commit to ruby/ruby that referenced this pull request Jun 13, 2023
@st0012 @matzbot
[ruby/irb] Stanardise test class names with Test postfix instead
91b106f 
of prefix
(ruby/irb#603)

ruby/irb@359cb28def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasumikin hasumikin hasumikin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@st0012 @hasumikin