Encapsulate input details in Statement objects #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
approved these changes
Aug 16, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 16, 2023
(ruby/irb#682) * Introduce Statement class * Split Statement class for better clarity ruby/irb@65e8e68690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #575 is merged, a single input can be handled differently under different context. And if we still pass them around as plain text, we always need to parse them whenever we need to perform a check (e.g. if it's a command). It also means the input processing flow is filled with regexp that could be hard to interpret over time.