Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require prism >= 0.18.0 #778

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Require prism >= 0.18.0 #778

merged 2 commits into from
Nov 22, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Nov 21, 2023

MatchWriteNode#locals is changed to MatchWriteNode#targets
CaseNode(case-when and case-in) is split to CaseNode and CaseMatchNode

@tompng tompng force-pushed the prism_match_write_case_match branch from b1cc675 to 1ddf177 Compare November 22, 2023 03:25
@tompng tompng changed the title Prism match write case match Require prism >= 0.18.0 Nov 22, 2023
@tompng tompng marked this pull request as draft November 22, 2023 03:33
@tompng tompng force-pushed the prism_match_write_case_match branch from 1ddf177 to f7099b1 Compare November 22, 2023 03:43
@tompng tompng marked this pull request as ready for review November 22, 2023 04:09
@st0012 st0012 merged commit 943c14b into ruby:master Nov 22, 2023
24 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 22, 2023
@tompng @matzbot
[ruby/irb] Require prism >= 0.18.0 (MatchWriteNode#targets and
8d6175b 
CaseMatchNode)
(ruby/irb#778)

ruby/irb@943c14b12e
@tompng tompng deleted the prism_match_write_case_match branch November 23, 2023 06:21
@st0012 st0012 added the enhancement New feature or request label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tompng @st0012