Simplify show_source's super calculation #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
refactor-show_source
branch
from
a8f7890
to
65c58be
Compare
tompng
reviewed
Dec 9, 2023
lib/irb/cmd/show_source.rb
Outdated
|
|
||
| if source | ||
| show_source(source) | ||
| elsif s_count | ||
| elsif super_level |
There was a problem hiding this comment.
I think comparing with 0 is missing. super_level is changed to be always a number.
There was a problem hiding this comment.
Good catch 👍
I also added a test case for it.
st0012
force-pushed
the
refactor-show_source
branch
from
65c58be
to
5948125
Compare
tompng
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can simplify
show_sourcecommand's-sflag handling by removing the possibility to have itnil.I'm also working on a more sophisticated flag parsing mechanism for all commands. And this change will help simplify that solution too.