Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish the exit! command and its tests #867

Merged
merged 6 commits into from
Feb 11, 2024
Merged

Polish the exit! command and its tests #867

merged 6 commits into from
Feb 11, 2024

Commits on Feb 10, 2024

  1. Remove IRB.irb_exit! method 

    It's not necessary to introduce a new method just for the exit! command
at this moment.
    @st0012
    st0012 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    247d419 View commit details
    Browse the repository at this point in the history

  2. Rename ExitForcedAction to ForceExit

    @st0012
    st0012 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    2f3705d View commit details
    Browse the repository at this point in the history

  3. Move force exit tests to a dedicated file

    @st0012
    st0012 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    77c4391 View commit details
    Browse the repository at this point in the history

  4. Fix nested history saving with exit! command 

    Because we switched to use `Kernel#exit` instead of `exit!`, the outer
session's ensure block in `Irb#run` will be run, which will save the
history. This means the separate check to save history when force exiting
is no longer necessary.
    @st0012
    st0012 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    22842b7 View commit details
    Browse the repository at this point in the history

  5. execute_lines helper should also capture IRB setup's output 

    This prevents setup warnings from being printed to test output
while allowing those output to be tested.
    @st0012
    st0012 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    441c9fb View commit details
    Browse the repository at this point in the history

  6. Update readme

    @st0012
    st0012 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    7ed98c8 View commit details
    Browse the repository at this point in the history