Fix an error for using parameterizing rules with own stack in semantic action #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c action ``` tool/lrama/lib/lrama/grammar/code/rule_action.rb:58:in 'Integer#+': nil can't be coerced into Integer (TypeError) ```
ydah
force-pushed
the
fix-error-when-use-own-stack
branch
from
b3a1e4b
to
6e36867
Compare
yui-knk
reviewed
Apr 26, 2024
| @@ -25,6 +25,7 @@ static int yyerror(YYLTYPE *loc, const char *str); | |||
| { | |||
| $$ = $1 + $2; | |||
| printf("(%d, %d)\n", $1, $2); | |||
There was a problem hiding this comment.
[note] $n could be used with skip_preprocess_references: true because Reference#index is set by #scan_reference then no need to fill index by #numberize_references (#preprocess_references)
lrama/lib/lrama/lexer/token/user_code.rb
Line 43 in 3b1ade0
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error.