Implement named references #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yui-knk
reviewed
Jun 12, 2023
lib/lrama/lexer.rb
Outdated
| @@ -257,6 +288,9 @@ def lex_user_code(ss, line, column, lines) | |||
| when ss.scan(/\$(<[a-zA-Z0-9_]+>)?(\d+)/) # $1, $2, $<long>1 | |||
| tag = ss[1] ? create_token(Token::Tag, ss[1], line, str.length) : nil | |||
| references << [:dollar, Integer(ss[2]), tag, str.length, str.length + ss[0].length - 1] | |||
| when ss.scan(/\$(<[a-zA-Z0-9_]+>)?([a-zA-Z0-9_]+)/) # $foo, $expr, $<long>program | |||
There was a problem hiding this comment.
I guess the second capture ([a-zA-Z0-9_]+) might be same with the capture for Token::Named_Ref except for [] (so that [a-zA-Z_.][-a-zA-Z0-9_.]*).
There was a problem hiding this comment.
Sorry, exactly saying ...
It might be same with one of two:
Token::Ident([a-zA-Z_.][-a-zA-Z0-9_.]*)Token::Named_Refexcept for[](so that[a-zA-Z_.][-a-zA-Z0-9_.]*)
There was a problem hiding this comment.
Thank you for reviewing. Is this the change you were suggesting?
3b8d4e5#diff-816037370d9ebaadd970a429ac66cdf5597623e3f285642396489c85b05b89c5R266
There was a problem hiding this comment.
Yes, if you have concerns, please let me know :)
junk0612
force-pushed
the
implement-named-references
branch
from
88a6e7b
to
811164f
Compare
|
Thanks for your PR, I left a comment. Other seems good. |
junk0612
force-pushed
the
implement-named-references
branch
from
811164f
to
faa4225
Compare
yui-knk
approved these changes
Jun 13, 2023
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request, I have implemented the Named References concept from bison.
By merging this pull request, it will be possible to refer to the value by its symbol in the rule or its alias from within the action.
Changes made