Use start_with? and end_with? over Regexp matching and Regexp.escape

ruby · Dec 3, 2016 · daa3c66 · daa3c66
1 parent f0e9719
commit daa3c66
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/mspec/runner/mspec.rb b/lib/mspec/runner/mspec.rb
@@ -347,16 +347,17 @@ def self.write_tag(tag)
   # file if it is empty.
   def self.delete_tag(tag)
     deleted = false
-    pattern = /#{tag.tag}.*#{Regexp.escape(tag.escape(tag.description))}/
+    desc = tag.escape(tag.description)
     file = tags_file
     if File.exist? file
       lines = IO.readlines(file)
       File.open(file, "wb") do |f|
         lines.each do |line|
-          unless pattern =~ line.chomp
-            f.puts line unless line.empty?
-          else
+          line = line.chomp
+          if line.start_with?(tag.tag) and line.end_with?(desc)
             deleted = true
+          else
+            f.puts line unless line.empty?
           end
         end
       end

diff --git a/spec/runner/mspec_spec.rb b/spec/runner/mspec_spec.rb
@@ -520,7 +520,7 @@
     MSpec.delete_tag(@tag).should == true
     MSpec.delete_tag(SpecTag.new("incomplete:The#best method ever")).should == true
     MSpec.delete_tag(SpecTag.new("benchmark:The#fastest method today")).should == true
-    MSpec.delete_tag(SpecTag.new("extended:\"Multi-line\ntext\ntag\"")).should == true
+    MSpec.delete_tag(SpecTag.new('extended:"Multi-line\ntext\ntag"')).should == true
     File.exist?(tmp("tags.txt", false)).should == false
   end
 end