Replace Timeout.timeout in Net:HTTP#connect

Use Socket.tcp's connect_timeout option instead
ruby · Jan 29, 2021 · 753cae3 · 753cae3 · danielwaterworth · Feb 7, 2023
1 parent d9ba437
commit 753cae3
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/lib/net/http.rb b/lib/net/http.rb
@@ -982,14 +982,13 @@ def connect
       end
 
       D "opening connection to #{conn_addr}:#{conn_port}..."
-      s = Timeout.timeout(@open_timeout, Net::OpenTimeout) {
-        begin
-          TCPSocket.open(conn_addr, conn_port, @local_host, @local_port)
-        rescue => e
-          raise e, "Failed to open TCP connection to " +
-            "#{conn_addr}:#{conn_port} (#{e.message})"
-        end
-      }
+      begin
+        s = Socket.tcp conn_addr, conn_port, @local_host, @local_port, connect_timeout: @open_timeout
+      rescue => e
+        e = Net::OpenTimeout.new(e) if e.is_a?(Errno::ETIMEDOUT) #for compatibility with previous versions
+        raise e, "Failed to open TCP connection to " +
+          "#{conn_addr}:#{conn_port} (#{e.message})"
+      end
       s.setsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY, 1)
       D "opened"
       if use_ssl?