parsing add case-sensitive headers with '@' #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Oct 30, 2023
Comment on lines
+225
to
+226
| if(name[0] == '@') | ||
| name.gsub('@', '') |
There was a problem hiding this comment.
Looks an interesting idea, but ambiguous a little.
This checks the first letter only but deletes all @.
What do you expect when name contains an @ in the middle?
nobu
changed the title
|
hi @GodKelvin @nobu is there any update on this PR? would like to have this feature be merged which will be helpful in certain case where the 3rd-party API server is not following the RFC standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because in some applications the header is sensitive, for this, if I pass an '@', I make the same value in header, without capitalize. For example, I have a request for API make in C#, him break if I pass 'Token' but worked if I pass 'token', because he not follow the RFC.