[DOC] Enhanced RDoc for Net::HTTP #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
reviewed
Dec 3, 2022
lib/net/http/requests.rb
Outdated
| # | ||
| # Related: | ||
| # | ||
| # - Net::HTTP.delete: sends +DELETE+ request, returns response object. |
There was a problem hiding this comment.
There also doesn't seem to be a Net::HTTP.delete method.
lib/net/http/requests.rb
Outdated
| # | ||
| # Related: | ||
| # | ||
| # - Net::HTTP.options: sends +OPTIONS+ request, returns response object. |
lib/net/http/requests.rb
Outdated
| # | ||
| # Related: | ||
| # | ||
| # - Net::HTTP.trace: sends +TRACE+ request, returns response object. |
lib/net/http/requests.rb
Outdated
| # | ||
| # Related: | ||
| # | ||
| # - Net::HTTP.patch: sends +PATCH+ request, returns response object. |
peterzhu2118
reviewed
Dec 4, 2022
I don;t know what to say, other than, "Yes, you're right." They're not here, but that's not for a documentation PR to deal with (even if it needs to be dealt with). |
|
I'm not sure I understand what you mean? You're mentioning methods that don't exist in the "Related" section. |
|
@peterzhu2118, ready for you now. |
peterzhu2118
approved these changes
Dec 4, 2022
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for classes
Net::HTTP::verb for 15 verbs (HTTP and WebDAV). Adds links to those pages fromNet::HTTPRequest.Reviewers, you can verify the given properties at https://en.wikipedia.org/wiki/Hypertext_Transfer_Protocol#Properties_of_request_methods_table.