Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Enhanced RDoc for Net::HTTP #89

Merged
merged 2 commits into from Dec 14, 2022
Merged

[DOC] Enhanced RDoc for Net::HTTP #89

merged 2 commits into from Dec 14, 2022

Conversation

BurdetteLamar
Copy link
Member

Treats:

  • #inspect
  • #set_debug_output
  • #response_body_encoding=
  • #ipaddr
  • #ipaddr=
  • #max_retries=

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Dec 13, 2022
lib/net/http.rb Outdated
Comment on lines 1041 to 1042
# http.max_retries = 2.9 # => 2.9
# http.max_retries # => 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it's converting it to an integer, but this is a really weird example, let's not encourage people to set floats for these kinds of values 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two lines removed from examples.

@peterzhu2118 peterzhu2118 merged commit 86b84eb into ruby:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

None yet

2 participants