Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out response parser (etc) into multiple files #10

Closed
nevans opened this issue Nov 14, 2020 · 2 comments
Closed

Split out response parser (etc) into multiple files #10

nevans opened this issue Nov 14, 2020 · 2 comments

Comments

@nevans
Copy link
Collaborator

nevans commented Nov 14, 2020

I would find it much easier to work with if net/imap.rb were split into several files. Would a patch like that be welcome and accepted? Just let me know, and I'll submit a PR right away (and if it's accepted, I'll rebase all existing PRs on it).

e.g:

  • net/imap/response_parser.rb for Net::IMAP::ResponseParser
  • net/imap/response_data.rb for the response data Structs (e.g. TaggedResponse, FetchData, MailboxList, etc)
  • net/imap/command_data.rb for all of the #send_data/#validate classes (like Atom, Literal, QuotedString, etc)
  • net/imap/authenticators.rb
    • net/imap/authenticators/{cram_md5,login,plain} etc
@shugo
Copy link
Member

shugo commented Mar 10, 2021

@nevans Thanks for your proposal.

Agreed. Such a PR is welcome!

nevans added a commit that referenced this issue May 5, 2021
nevans added a commit that referenced this issue May 5, 2021
nevans added a commit that referenced this issue May 5, 2021
nevans added a commit that referenced this issue May 5, 2021
nevans added a commit that referenced this issue May 5, 2021
Partially implements #10.
nevans added a commit that referenced this issue May 5, 2021
@nevans
Copy link
Collaborator Author

nevans commented May 5, 2021

@shugo Other than the minor changes mentioned in #22 and a bunch of documentation updates (see 9cd562a), the code has simply been moved to different files without any changes. It matched my proposal here so I pushed them directly. Let me know if you think we ought to organize anything differently. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants