-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out response parser (etc) into multiple files #10
Comments
@nevans Thanks for your proposal. Agreed. Such a PR is welcome! |
@shugo Other than the minor changes mentioned in #22 and a bunch of documentation updates (see 9cd562a), the code has simply been moved to different files without any changes. It matched my proposal here so I pushed them directly. Let me know if you think we ought to organize anything differently. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would find it much easier to work with if net/imap.rb were split into several files. Would a patch like that be welcome and accepted? Just let me know, and I'll submit a PR right away (and if it's accepted, I'll rebase all existing PRs on it).
e.g:
net/imap/response_parser.rb
forNet::IMAP::ResponseParser
net/imap/response_data.rb
for the response data Structs (e.g.TaggedResponse
,FetchData
,MailboxList
, etc)net/imap/command_data.rb
for all of the#send_data
/#validate classes
(likeAtom
,Literal
,QuotedString
, etc)net/imap/authenticators.rb
net/imap/authenticators/{cram_md5,login,plain}
etcThe text was updated successfully, but these errors were encountered: