Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UIDPLUS extension #65

Merged
merged 6 commits into from
Oct 15, 2022
Merged

Support UIDPLUS extension #65

merged 6 commits into from
Oct 15, 2022

Conversation

hoffi
Copy link
Contributor

@hoffi hoffi commented Oct 14, 2022

Fixes #36.

Added the UID EXPUNGE command and parses the APPENDUID, COPYUID and UIDNOTSTICKY responses.
I also modified the append, copy and move methods to return those UIDs when they are present in the response.

I have also tested this against a production Dovecot IMAP server and a Microsoft 365 account.

nevans
nevans approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@nevans nevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using a regexp hack for almost a decade. This is great, thanks!

lib/net/imap.rb Outdated Show resolved Hide resolved
lib/net/imap.rb Outdated Show resolved Hide resolved
lib/net/imap.rb Outdated Show resolved Hide resolved
lib/net/imap.rb Outdated Show resolved Hide resolved
lib/net/imap.rb Outdated Show resolved Hide resolved
lib/net/imap/response_parser.rb Outdated Show resolved Hide resolved
lib/net/imap/response_parser.rb Outdated Show resolved Hide resolved
lib/net/imap/response_parser.rb Outdated Show resolved Hide resolved
test/net/imap/test_imap.rb Outdated Show resolved Hide resolved
nevans
nevans reviewed Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@nevans nevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another tiny suggestion, a small rdoc improvement.

lib/net/imap.rb Outdated Show resolved Hide resolved
lib/net/imap.rb Outdated Show resolved Hide resolved
@nevans nevans merged commit a582798 into ruby:master Oct 15, 2022
@nevans
Copy link
Collaborator

nevans commented Oct 15, 2022

🎉 Thanks!

@nevans nevans mentioned this pull request Feb 12, 2023
Open
@nevans nevans added the IMAP4rev2 Requirement for IMAP4rev2, RFC9051 label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevans nevans nevans approved these changes

Assignees
No one assigned
Labels
IMAP4rev2 Requirement for IMAP4rev2, RFC9051
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC4315 (2005): UIDPLUS (included in IMAP4rev2)
2 participants
@hoffi @nevans