Fixes date-time format, and adds decode_datetime #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at https://rubygems.org/gems/date/reverse_dependencies, it looks like there aren't any very large/popular gems with a dependency on |
nevans
force-pushed
the
bugfix-encode_datetime
branch
from
b81dc9e
to
bc30109
Compare
`Net::IMAP.format_datetime` was previously using an incorrect
`date-time` format (see the `Net::IMAP::STRFDATE` rdoc). I don't know
if anyone actually *uses* `format_datetime`, but fixing the bug isn't
backwards compatible. I implemented the correct behavior under a
different method name (and an alias). The existing method keeps its
original behavior (for now), with a warning that it will be fixed in a
future version.
Also:
* adds "date" gem as a dependency
* adds `{format,parse}_date` methods.
* updates `send_data`
* adds `Date` handling. This can be used by `SEARCH`.
* uses `encode_datetime` from `send_time_data` (reduces duplication)
* adds aliases
* `format_*` => `encode_*`
* `parse_*` => `decode_*`
* `encode_time` => `encode_datetime`
* but `decode_time` returns a Time object
nevans
force-pushed
the
bugfix-encode_datetime
branch
from
bc30109
to
bcd1f4b
Compare
shugo
approved these changes
Oct 30, 2022
|
There is a major issue with I install Ruby from distro packages and then a set of pure Ruby gems but net-imap is no longer pure. |
nevans
added a commit
to nevans/net-imap
that referenced
this pull request
Nov 6, 2023
This modifies the code I added in ruby#66 to make it more useful when `date-time` is parsed as a `quoted` string (as it currently is). I'd prefer that `date-time` values were simply parsed as DateTime objects in the ResponseParser, but that has backwards compatibility issues.
nevans
added a commit
to nevans/net-imap
that referenced
this pull request
Nov 6, 2023
This modifies the code added in ruby#66 to make it more useful when `date-time` is parsed as a `quoted` string (as it currently is). I'd prefer that ResponseParser simply parse `date-time` values as DateTime objects, but that has backwards compatibility issues.
nevans
added a commit
to nevans/net-imap
that referenced
this pull request
Nov 6, 2023
This modifies the code added in ruby#66 to make it more useful when `date-time` is parsed as a `quoted` string (as it currently is). I'd prefer that ResponseParser simply parse `date-time` values as DateTime objects, but that has backwards compatibility issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes date-time format, and adds decode_datetime.
Also:
send_data. This will be used by search.I don't know if anyone is actually using Net::IMAP.format_datetime. If they are, then fixing the bug will not be backwards compatible. Since "encode" and "decode" are a natural pair (and we already had "encode_utf7"), I added new methods with those names and added deprecation warnings to the old methods.