Net::SMTP.start arguments are keyword arguments #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the test too. |
tmtm
force-pushed
the
start_keyword_arguments
branch
from
d88e95b
to
c1bc96b
Compare
The helo argument is not important, but the helo argument must be specified to specify the user and secret arguments. If helo, user, secret, and authtype arguments are keyword arguments, it is not necessary to specify the helo argument.
tmtm
force-pushed
the
start_keyword_arguments
branch
from
c1bc96b
to
269774d
Compare
|
I added test. |
knu
approved these changes
Jul 20, 2020
|
I agree that keyword arguments are far more intuitive than a handful of positional arguments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helo argument is not important, but the helo argument must be specified to specify the user and secret arguments.
If helo, user, secret, and authtype arguments are keyword arguments, it is not necessary to specify the helo argument.