Fix version extraction to work with non ASCII characters with any LANG
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9fe72a introduced a non-ASCII character (U+2014) in comment but Regex match failed with non UTF-8 locale. This commit fixes it by specifying encoding explicitly.
kateinoigakukun
added a commit
to kateinoigakukun/ruby
that referenced
this pull request
Jan 4, 2024
kateinoigakukun
added a commit
to kateinoigakukun/ruby
that referenced
this pull request
Jan 4, 2024
See the following PRs for details: * ruby/net-smtp#76 * ruby/net-smtp#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d9fe72a introduced a non-ASCII character (U+2014) in comment but Regex match failed with non UTF-8 locale.
The extraction failure results in the following build error while building ruby with
gems/bundled_gemsincluding git-revision specified net-smtp.https://rubyci.s3.amazonaws.com/debian-riscv64/ruby-master/log/20240104T070017Z.fail.html.gz
This commit fixes it by specifying encoding explicitly.