Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to write "DO" to respond to "IAC WILL x". #15

Closed

Conversation

junaruga
Copy link
Member

When running a code analysis tool, I got an error

copy_paste_error: "DONT" in "IAC + DONT" looks like a copy-paste error.

for the below line. There are same lines both WILL[0] == $1[0] and WONT[0] == $1[0] cases in preprocess method.

self.write(IAC + DONT + $1[1..1])

I am not so confident for my modification, because I am not familiar with the telnet protocol.

@znz
Copy link
Member

znz commented Sep 20, 2018

I think DONT means it cannot handle the option.
So I think it is intentional.

http://pcmicro.com/netfoss/telnet.html

WILL | DONT | Receiver says it cannot support the option. Option is not in effect.

@znz znz closed this Sep 20, 2018
@junaruga
Copy link
Member Author

@znz alright. Thank you for checking it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants